ui: Fix icons aligning for Timeframe navigation buttons#50010
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 15, 2020
Merged
ui: Fix icons aligning for Timeframe navigation buttons#50010craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
vladlos
reviewed
Jun 11, 2020
vladlos
approved these changes
Jun 11, 2020
Contributor
vladlos
left a comment
There was a problem hiding this comment.
I couldn't recreate original issue, but this change also do not brake anything so LGTM
44e89b0 to
0ced6c9
Compare
dhartunian
approved these changes
Jun 12, 2020
Time frame navigation buttons had icons which weren't aligned vertically before. Now, content of navigation buttons is centered. Release note (admin ui change): Fix icons aligning for Timeframe navigation buttons.
0ced6c9 to
3a2d09e
Compare
Contributor
Author
|
bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #49862
Time frame navigation buttons had icons which
weren't aligned vertically before.
Now, the content of navigation buttons is centered.
Before:


After:

