opt: incorporate cast volatility#49779
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 4, 2020
Merged
Conversation
Member
|
This change is |
mgartner
approved these changes
Jun 3, 2020
Contributor
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 36 of 36 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @rytaft)
pkg/sql/sem/tree/casts.go, line 117 at r1 (raw file):
{from: types.GeometryFamily, to: types.GeographyFamily, volatility: VolatilityImmutable}, // Casts to GeographyFamily.
[nit] Should be GeometryFamily.
This change incorporates the new cast volatility information into the VolatilitySet property. Release note: None
ad3ac8d to
6517319
Compare
rytaft
approved these changes
Jun 3, 2020
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 4 of 36 files at r1, 1 of 1 files at r2.
Reviewable status:
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 4, 2020
49779: opt: incorporate cast volatility r=RaduBerinde a=RaduBerinde This change incorporates the new cast volatility information into the VolatilitySet property. Release note: None 49823: adding myself to AUTHORS r=DrewKimball a=DrewKimball Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Drew Kimball <drewk@cockroachlabs.com>
Contributor
Timed out (retrying...) |
Member
Author
|
bors r- |
Contributor
Canceled |
Member
Author
|
bors r+ |
Contributor
Merge conflict (retrying...) |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change incorporates the new cast volatility information into the
VolatilitySet property.
Release note: None