Multiraft Transport implementation#483
Merged
bdarnell merged 6 commits intocockroachdb:masterfrom Mar 31, 2015
Merged
Conversation
Contributor
|
@bdarnell thanks a lot for completing this, was hoping to finish it this week but you beat me to it :) |
server/transport.go
Outdated
Member
There was a problem hiding this comment.
It seems like this might be better named raft_transport.go or perhaps just raft.go.
Also, change copyright to 2015.
Adapt to upstream changes to gossip.New. Add some extra logging. Needs to be changed before merging to not create a goroutine per rpc.
server/transport.go
Outdated
Member
There was a problem hiding this comment.
Could we fix up this comment? It's a little vague.
Member
|
LGTM |
Unexport the rpcTransport type. Update header comments.
ae62867 to
c513103
Compare
Contributor
Author
|
PTAL with the cockroach/rpc/client changes. |
Member
|
LGTM |
bdarnell
added a commit
that referenced
this pull request
Mar 31, 2015
Multiraft Transport implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up from @tnachen's #292, this PR adds an implementation of multiraft.Transport that uses gossip for addressing, enabling it to be used with multiple nodes. This also required changes to use protobufs on the wire, instead of gob encoding as in LocalRPCTransport.