ui: CSS modules for Statements Details page#48090
Merged
craig[bot] merged 6 commits intocockroachdb:masterfrom Jun 9, 2020
Merged
ui: CSS modules for Statements Details page#48090craig[bot] merged 6 commits intocockroachdb:masterfrom
craig[bot] merged 6 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
|
❌ The GitHub CI (Cockroach) build has failed on aedd9aab. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
aedd9aa to
3e6257a
Compare
|
❌ The GitHub CI (Cockroach) build has failed on 3e6257a3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
3e6257a to
b6040c2
Compare
b6040c2 to
ea65295
Compare
|
❌ The GitHub CI (Cockroach) build has failed on 1698c081. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
1e37cee to
ecba058
Compare
ecba058 to
668623b
Compare
This change refactors following components to use CSS modules instead of styles defined as global: - Dropdown - Search - PageConfig Release note: None
Release note: None
Release note: None
Following components are refactored to use CSS modules instead of global styles: - Statement Details page - Statements Diagnostics components - Anchor - Text - Empty Before, `Empty` component had styles which override Text, and Anchor components. Now, these styles are passed via `className` component props and custom styles defined by outer component. Release note: None
Statement Details pages has four tabs which aren't controlled and it wasn't possible to open particular tab and render it in storybook. It is also led to usability issue where selected tab was not preserved after page refresh. With current commit: - selected tab is tracked as search param in URL - added storybook for Statement Details page for every tab except Diagnostics tab. Content of Diagnostics tab is independent connected view and has to be defined in it's own storybook. Release note (admin ui change): preserve selected tab in Statement Details page after reload.
Instead of accessing to CSS modules class names as fields, `classnames/bind` function is used to bind class names to hashed names in imported CSS module file. Release note: None
668623b to
87f78ee
Compare
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 9, 2020
48155: ui: CSS modules for Button component r=koorosh a=koorosh Depends on #48090 Related to #47527 Before, Button component had styles defined with own namespacing and now styles are imported as CSS module. The main change is separation BackIcon component which was coupled with Button and the way custom styles were applied to display button as a link without highlighting. - BackIcon is refactored to it's own module with styles - custom styles are applied with new Button type option - `unstyled-link`. Release note: None 48217: ui: CSS modules for SqlBox components r=koorosh a=koorosh Depends on #48155 Related to #47527 Refactor following components to use CSS modules instead of global styles: - SqlBox - highlight Note, `hljs-` classes are 3rd-party styles which are overriden with custom styles. Release note: None 48234: ui: CSS modules for Badge component r=koorosh a=koorosh Depends on #48217 Related to #47527 Define styles for Badge component as CSS modules. Release note: None Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #48012
Related to #47527
Following components are refactored to use CSS modules
instead of global styles:
Before,
Emptycomponent had styles which overrideText, and Anchor components. Now, these styles are
passed via
classNamecomponent props and customstyles defined by outer component.
Release note: None