ui: CSS modules for PlanView component#47513
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Jun 4, 2020
Merged
Conversation
Member
|
❌ The GitHub CI (Cockroach) build has failed on f5c48070. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
f5c4807 to
e57229c
Compare
|
❌ The GitHub CI (Cockroach) build has failed on e57229c4. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
e57229c to
34de871
Compare
23 tasks
|
❌ The GitHub CI (Cockroach) build has failed on 34de8711. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
34de871 to
ac7e6c5
Compare
a70787d to
2007146
Compare
af4d5a8 to
cccd35c
Compare
9c7afcf to
3ab52bb
Compare
a312e4b to
aae59a3
Compare
To test styles isolation for statements page we need storybook which displays entire Statements screen only. To make it work, RouterProvider decorator is added which connects router to dummy (empty) store. `statementsPage.fixture.ts` file contains snapshot of required props for StatementsPage component Release note: None
- refactor fonts imports to correctly resolve paths when module is required from different locations; - move all files related to PlanView component under `planView` directory - Added story for PlanView component Release note: None
Previously, class names were constructed by simply accessing style modules class names and assigning it to classes. It was cumbersome and not readable at all. To enhance this, `classnames/bind` alternate is used, which allows simply put class names. Release note: None
aae59a3 to
5fff70b
Compare
dhartunian
approved these changes
Jun 4, 2020
Contributor
Author
|
bors r+ |
Contributor
Merge conflict (retrying...) |
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 4, 2020
47606: ui: CSS modules for Table components r=koorosh a=koorosh Depends on #47513 Related to #47527 This change refactors components to use CSS modules and incorporate all required styles without any external dependencies and prevent styles altering from outside. It affects several components which tightly coupled with StatementsTable and couldn't be changed separately. Following component are changed: - HighlightedText - Drawer - StatementsTable - SortableTable Note, that `StatementsTable#makeCommonColumns` function is refactored to provide custom styles from parent to child components via props instead of overriding styles. Storybook is extended to show some components as independent units or in context of `StatementTable` component (if it is only the way components work). Release note: None 49770: changefeedccl: change default flush interval to 5s r=dt a=dt We observed a customer cluster's changefeeds to cloud storage 'getting stuck' which on further investigation was determined to be happening because they were spending too much time in flushing. This was because they were writing to a cloud sink and the default flush interval of 200ms (poller interval of 1s / 5) meant it spent all of its time flushing. This default was picked testing with lower-latency sinks and was noted in a comment as somewhat arbitrary. This change does two things: it increases the default to the poller interval if unspecified, instead of poller interval / 5, meaning 1s instead of 200ms at the default setting, and if the sink being used is cloud storage, it changes it to the greater of that or 5s. Users who truely desire lower latency can of course specify their own 'resolved' interval, so this change in the default is for those that are indifferent, and increasing the latency to 1s or 5s reduces the chance of hiitting this unfortunate edge case when the sink is too slow. Release note (enterprise change): The default flush interval for changefeeds that do not specify a 'resolved' option is now 1s instead of 200ms, or 5s if the changefeed sink is cloud-storage. 49819: Use faster set for column IDs in schemaexpr r=mgartner a=mgartner #### sqlbase: add ColSet wrapper for util.FastIntSet of ColumnID There are numerous places where a `map[sqlbase.ColumnID]struct{}` or a `util.FastIntSet` is used to represent a set of `sqlbase.ColumnID`. This commit adds a typed wrapper around `util.FastIntSet` which is an efficient and ergonimic replacement for maps and `util.FastIntSet`. Release note: None #### schemaexpr: use sqlbase.ColSet instead of maps This commit replaces maps used as sets of integers with sqlbase.ColSet because it is a more efficient set implementation. Release note: None Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com> Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #47484
Related to: #47527
Fonts are imported directly from
app.stylfile which allows importtypography.stylwithout dependencies. This change was required because importingtypography.stylfile from CSS modulesfailed with unresolved paths inside of
fonts.stylfile (which was required intypography.stylfile).Before,
Now:
planViewdirectoryPlanViewcomponentplanView.module.stylfile contains copy of styles (fromstatements.styl) which is used by component only.Release note: None