storage/concurrency: clean up lockTable datadriven tests#45147
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Feb 18, 2020
Merged
storage/concurrency: clean up lockTable datadriven tests#45147craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
…ble tests Suggested in cockroachdb#45062.
…art-waiting/should-wait/ Suggested in cockroachdb#45062. Addresses TODOs.
ae96420 to
d42250d
Compare
Contributor
Author
|
Rebased on #45124, so this should be ready for a look now. |
sumeerbhola
approved these changes
Feb 18, 2020
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola and @tbg)
Contributor
Author
|
bors r+ |
Contributor
Author
|
Bors was canceled even though CI passed... bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 18, 2020
45147: storage/concurrency: clean up lockTable datadriven tests r=nvanbenschoten a=nvanbenschoten This PR contains three small improvements that were suggested in #45062 by @tbg: - prefix creation directives with "new-" - rename `done` directive to `dequeue` - rename `guard-start-waiting` directive to `should-wait` @sumeerbhola I'll let you decide how you'd like to sequence this with #45124. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains three small improvements that were suggested in #45062 by @tbg:
donedirective todequeueguard-start-waitingdirective toshould-wait@sumeerbhola I'll let you decide how you'd like to sequence this with #45124.