libroach: fix format specifier#44583
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 31, 2020
Merged
Conversation
In cockroachdb#44553 I used the wrong format specifier for an int64_t in libroach. While it did not break the build it seems to break something for developers using their local compiler (MacOS?). Release note: None
Member
|
This change is |
yuzefovich
approved these changes
Jan 31, 2020
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 31, 2020
44583: libroach: fix format specifier r=ajwerner a=ajwerner In #44553 I used the wrong format specifier for an int64_t in libroach. While it did not break the build it seems to break something for developers using their local compiler (MacOS?). Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Contributor
Build succeeded |
petermattis
reviewed
Jan 31, 2020
Collaborator
petermattis
left a comment
There was a problem hiding this comment.
Reviewable status:
c-deps/libroach/db.cc, line 1159 at r1 (raw file):
const int64_t new_size = cur_size + decoded_key.size() + iter.value().size(); if (max_size > 0 && new_size > max_size) { return FmtStatus("export size (%" PRIi64 " bytes) exceeds max size (%" PRIi64 " bytes)",
I detest these format specifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #44553 I used the wrong format specifier for an int64_t in libroach.
While it did not break the build it seems to break something for developers
using their local compiler (MacOS?).
Release note: None