Skip to content

jobs: always set start time of a job#44551

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
spaskob:start-time
Jan 30, 2020
Merged

jobs: always set start time of a job#44551
craig[bot] merged 1 commit intocockroachdb:masterfrom
spaskob:start-time

Conversation

@spaskob
Copy link
Copy Markdown
Contributor

@spaskob spaskob commented Jan 30, 2020

When starting a job via CreateAndStartJob if
making the job started fails the job will stil be
in system.jobs and can be adopted by another
node later but the started time will be 0 in this
case. We add a check and set it if necessary.

Release note: none.

When starting a job via CreateAndStartJob if
making the job started fails the job will stil be
in system.jobs and can be adopted but the started
time will be 0. In that case mark it with the
current time.

Release note: none.
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@spaskob spaskob requested a review from thoszhang January 30, 2020 18:11
Copy link
Copy Markdown

@thoszhang thoszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@spaskob
Copy link
Copy Markdown
Contributor Author

spaskob commented Jan 30, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 30, 2020

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request Jan 30, 2020
44489: sql: bugfixes around writing the old primary key in pk changes r=rohany a=rohany

This PR fixes two bugs:
* The logic for when to rewrite the old primary key was broken
  resulting in the old primary key not being rewritten in many cases.
* The old primary key being created was not properly dealing with
  its dangling interleave information.

This PR makes the design decision to not re-interleave the copy of the old primary index if it was interleaved.

Release note: None

44551: jobs: always set start time of a job r=spaskob a=spaskob

When starting a job via CreateAndStartJob if
making the job started fails the job will stil be
in system.jobs and can be adopted by another
node later but the started time will be 0 in this
case. We add a check and set it if necessary.

Release note: none.

44553: engine: redefine targetSize and add maxSize to ExportToSst r=itsbilal a=ajwerner

This PR is a follow-up of work from #44440 motivated by problems unearthed while typing #44482. The PR comes in two commits:

1) Re-define `targetSize` from being a target below which most requests would remain to being the size above which the export stops.
2) Add a `maxSize` parameter above which the `ExportToSst` call will fail.

See the individual commits for more details. 

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Co-authored-by: Spas Bojanov <spas@cockroachlabs.com>
Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 30, 2020

Build succeeded

@craig craig bot merged commit bd90489 into cockroachdb:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants