kv: small readability improvement to the heartbeat#44461
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 28, 2020
Merged
kv: small readability improvement to the heartbeat#44461craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Rearrange protection against a race to make it more obvious. A casual reading suggested to me that this protection was missing. Release note: None
Member
nvb
approved these changes
Jan 28, 2020
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 28, 2020
44429: sql: propagate row-level locking modes through execbuilder to row.Fetcher r=nvanbenschoten a=nvanbenschoten Relates to #40205. This commit is a follow-up to #44015. It propagates the row-level locking modes from the optbuilder all the way down to the row.Fetcher. This requires passing the locking information through the execbuilder and then through DistSQL. The commit leaves off at the point where `roachpb.ScanRequest`s are constructed. I couldn't find a good way to test this. It's possible I missed something and would love any tips, but I think we may need to wait until the plumbing into the KV API is complete before performing end-to-end tests. The next step will be to hook the locking modes into the KV API. Release note: None 44446: roachtest: don't use 20.1 nodelocal on older versions r=dt a=dt The ability to target the nodelocal directory *of a particular node* was added in 20.1, so when roachtesting earlier versions we still need to use the old google cloud storage bucket. Release note: none. 44461: kv: small readability improvement to the heartbeat r=andreimatei a=andreimatei Rearrange protection against a race to make it more obvious. A casual reading suggested to me that this protection was missing. Release note: None 44463: kv: simplify retriable error handling r=andreimatei a=andreimatei The contract of handleRetryableErrLocked() was weird for no discernible reason. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rearrange protection against a race to make it more obvious. A casual
reading suggested to me that this protection was missing.
Release note: None