builtins: fix to_english(math.MinInt64)#44251
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 23, 2020
Merged
Conversation
Member
|
This change is |
yuzefovich
approved these changes
Jan 23, 2020
Member
yuzefovich
left a comment
There was a problem hiding this comment.
[nit]: I'd use MinInt64 in the release note as well. Also, it would not crash but return an internal error.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @solongordon)
Release note (bug fix): `TO_ENGLISH(math.MinInt64)` previously errored. This is now fixed to return the correct result.
Contributor
Author
|
bors r=yuzefovich |
craig bot
pushed a commit
that referenced
this pull request
Jan 23, 2020
44170: sql: unify InternalExecutor and SessionBoundInternalExecutor r=andreimatei a=andreimatei The internal executor is a library that started bad and got worse. It came in two flavors: InternalExecutor and SessionBoundInternalExecutor. The interface was confusing, only matched by the implementation. And besides tomes of code, neither of them could do the basic thing of allowing a higher layer to bind most of the session data for future internal queries, but let the user be overriden at the query site. This patch does away with the SessionBoundInternalExecutor. It's functionality is absorbed into the InternalExecutor. The ie now gets a SetSessionData() method, used to bind session data. An extended query interface is added, allowing some aspects of this session data to be overriden on a per-query basis. Release note: None 44251: builtins: fix to_english(math.MinInt64) r=yuzefovich a=otan Resolves #44152. Release note (bug fix): `TO_ENGLISH(math.MinInt64)` previously errored. This is now fixed to return the correct result. Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #44152.
Release note (bug fix):
TO_ENGLISH(math.MinInt64)previouslyerrored. This is now fixed to return the correct result.