*: rename roachpb.EndTransactionRequest to EndTxnRequest#43387
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Dec 27, 2019
Merged
*: rename roachpb.EndTransactionRequest to EndTxnRequest#43387craig[bot] merged 3 commits intocockroachdb:masterfrom
craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
7b05180 to
9209bf4
Compare
andreimatei
reviewed
Dec 27, 2019
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
This commit renames all references to EndTransaction to EndTxn. This brings the name in line with all other transaction metadata requests (e.g. HeartbeatTxnRequest, PushTxnRequest, QueryTxnRequest, and RecoverTxnRequest), as was discussed in cockroachdb#42933. It also removes a lot of visual noise wherever the request type is used. All comments modified were re-wrapped to 80 characters. Release note: None
Strictly a rename. Release note: None
Release note: None
9209bf4 to
2b76acc
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 27, 2019
43387: *: rename roachpb.EndTransactionRequest to EndTxnRequest r=nvanbenschoten a=nvanbenschoten This commit renames all references to `EndTransaction` to `EndTxn`. This brings the name in line with all other transaction metadata requests (e.g. `HeartbeatTxnRequest`, `PushTxnRequest`, `QueryTxnRequest`, and `RecoverTxnRequest`), as was discussed in #42933. It also removes a lot of visual noise wherever the request type is used. All comments modified were re-wrapped to 80 characters. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames all references to
EndTransactiontoEndTxn. This brings the name in line with all other transaction metadata requests (e.g.HeartbeatTxnRequest,PushTxnRequest,QueryTxnRequest, andRecoverTxnRequest), as was discussed in #42933. It also removes a lot of visual noise wherever the request type is used.All comments modified were re-wrapped to 80 characters.