execinfrapb: print out input types for EXPLAIN (DISTSQL, TYPES)#43193
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 17, 2019
Merged
execinfrapb: print out input types for EXPLAIN (DISTSQL, TYPES)#43193craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
630365f to
955a32f
Compare
Member
|
How often do you think this will be useful? It adds a bit more clutter to already cluttered diagrams, and it makes the URLs longer. If it's just to debug specific cases, we could consider having an |
Member
Author
|
I don't think it'll be useful very often, and I like your suggestion about |
This change adds printing out the column types for InputSyncSpec in the flow diagram. This could be useful to understand the issue when a type mismatch occurs. Release note (sql change): Column types will now be displayed in the box for the input synchronizer in the flow diagram obtained via EXPLAIN (DISTSQL, TYPES).
955a32f to
0416a26
Compare
Member
Author
|
Updated the PR, RFAL. |
RaduBerinde
approved these changes
Dec 17, 2019
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @RaduBerinde)
Member
Author
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 17, 2019
43193: execinfrapb: print out input types for EXPLAIN (DISTSQL, TYPES) r=yuzefovich a=yuzefovich This change adds printing out the column types for InputSyncSpec in the flow diagram. This could be useful to understand the issue when a type mismatch occurs. Release note (sql change): Column types will now be displayed in the box for the input synchronizer in the flow diagram obtained via EXPLAIN (DISTSQL, TYPES). Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds printing out the column types for InputSyncSpec in the
flow diagram. This could be useful to understand the issue when a type
mismatch occurs.
Release note (sql change): Column types will now be displayed in the box
for the input synchronizer in the flow diagram obtained via EXPLAIN
(DISTSQL, TYPES).