storage/engine: clarify the MVCC history tests#43184
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 16, 2019
Merged
storage/engine: clarify the MVCC history tests#43184craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Suggested by @petermattis. This clarifies the `get` timestamps in `put_with_txn`. Release note: None
Member
|
This change is |
petermattis
reviewed
Dec 16, 2019
Collaborator
petermattis
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @petermattis)
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 16, 2019
43184: storage/engine: clarify the MVCC history tests r=knz a=knz Suggested by @petermattis in #42250 (review). This clarifies the `get` timestamps in `put_with_txn`. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @petermattis in #42250 (review).
This clarifies the
gettimestamps input_with_txn.Release note: None