settings: explanatory comments around cluster settings#42991
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 5, 2019
Merged
settings: explanatory comments around cluster settings#42991craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
nvb
approved these changes
Dec 5, 2019
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @irfansharif)
pkg/settings/cluster/settings.go, line 99 at r1 (raw file):
// // During the node startup sequence, an initial version (persisted to the // engines) is read and passed to Initialize(). It is only after that
Mind rewrapping this?
Update stale references to changed method signatures and add a bit more documentation around the usage of IsActive. Release note: None
b36fbf0 to
e7a492e
Compare
irfansharif
commented
Dec 5, 2019
Contributor
Author
irfansharif
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @nvanbenschoten)
pkg/settings/cluster/settings.go, line 99 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Mind rewrapping this?
On a scale of 1-10, how strongly do you feel about this? 😛
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 5, 2019
42985: issues: simplify post() r=jordanlewis a=tbg This prepares the code for allowing the caller more control over the message body. This makes sense since post() is called both by roachtest and nightly stress, and it doesn't make sense to use the same message body for both. Release note: None 42986: roachprod: don't try to make long dns names r=dt a=dt long cluster names break DNS. Rather than break DNS for everyone, just skip the clusters that have these long names. DNS is a nice-to-have in any case, so it is OK to skip it -- roachprod will fallback to IPs. Release note: none. 42991: settings: explanatory comments around cluster settings r=irfansharif a=irfansharif Update stale references to changed method signatures and add a bit more documentation around the usage of IsActive. Release note: None 42998: sql: bugfixes in role membership caching r=petermattis a=rohany Fixes #42098. This PR fixes some bugs in role membership caching. * The role membership cache was a single global, which meant multiple servers in the same cockroach process could pollute the cache for each other, causing flaky test failures. * The cache updating mechanism seemed to use the incorrect variable to update the cache version when a concurrent request caused a cache invalidation as well. Although unlikely, this could have lead to incorrect results being served. Release note (bug fix): This change fixes some existing caching issues surrounding role memberships, where users could sometimes see out of date role membership information. Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com> Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com> Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update stale references to changed method signatures and add a bit more
documentation around the usage of IsActive.
Release note: None