Argh, this is a good one. One of the dependencies uses build tags that distinguish linux from OS X, so glock save ... does the wrong thing on OS X. I had to resort to build/builder.sh glock save ... to get the correct GLOCKFILE generated.

I gave the code a quick scan, overall looks good, but I'll do an in depth pass tomorrow morning. What version of docker are you running locally?

1.9.1
On Feb 10, 2016 01:56, "Bram Gruneir" notifications@github.com wrote:

I gave the code a quick scan, overall looks good, but I'll do an in depth
pass tomorrow morning. What version of docker are you running locally?

—
Reply to this email directly or view it on GitHub
#4282 (comment)
.

Cool. I'll test it against my setup with v1.10
On Feb 10, 2016 06:25, "Tamir Duberstein" notifications@github.com wrote:

1.9.1
On Feb 10, 2016 01:56, "Bram Gruneir" notifications@github.com wrote:

I gave the code a quick scan, overall looks good, but I'll do an in depth
pass tomorrow morning. What version of docker are you running locally?

—
Reply to this email directly or view it on GitHub
<
https://github.com/cockroachdb/cockroach/pull/4282#issuecomment-182230773>
.

—
Reply to this email directly or view it on GitHub
#4282 (comment)
.

LGTM, I'm going to try running it now.

Reviewed 2 of 4 files at r1, 5 of 5 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

acceptance/chaos_test.go, line 224 [r5] (raw file):
Feel strongly about this label? They always strike me as nasty. Maybe

madeProgress := func() bool {
  c.Assert(t)
  for i, client := .... { ... }
  return false
}

for !madeProgress() {
  time.Sleep(time.Second)
}

Comments from the review on Reviewable.io

Review status: 4 of 7 files reviewed at latest revision, 2 unresolved discussions.

acceptance/chaos_test.go, line 224 [r5] (raw file):
Done.

Comments from the review on Reviewable.io

OK this is finally green. @tschottdorf or @petermattis can I get sign-off?

LGTM

Also, passes locally with docker 1.10 for me.

Still trying to fix my Docker....... but LGTM

Reviewed 3 of 3 files at r6.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

acceptance/cluster/docker.go, line 102 [r6] (raw file):
I remember that error, and thought ignoring it fixed the issue (it still deleted it (?)). Have you checked?

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 1 unresolved discussion.

acceptance/cluster/docker.go, line 102 [r6] (raw file):
I don't know, actually. Let me try it in a follow-up PR in which I ignore the error.

Comments from the review on Reviewable.io