sql: remove local ordinality#42596
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 20, 2019
Merged
Conversation
Now that it's got a distributed version, we can delete the local implementation. Release note: None
Member
|
This change is |
rafiss
approved these changes
Nov 20, 2019
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 20, 2019
42572: sql: scan only primary column for FK checks r=RaduBerinde a=RaduBerinde This change improves the legacy FK path to only scan the primary column family. The new path already does this (as long as the best plan is a lookup join). Adding a test for both paths. Fixes #30852. Release note: None 42596: sql: remove local ordinality r=jordanlewis a=jordanlewis Now that it's got a distributed version, we can delete the local implementation. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Contributor
Build succeeded |
Member
|
The order of |
Member
Author
|
😰 I'll send a PR |
Member
|
While you're at it, it seems to me that |
Member
Author
|
Blah. This thing is terrible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that it's got a distributed version, we can delete the local
implementation.
Release note: None