cli/interactive_tests: opt out of telemetry by default#42537
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 18, 2019
Merged
cli/interactive_tests: opt out of telemetry by default#42537craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Prior to this patch, the CLI interactive tests were running with diagnostic reporting (including update server checks, telemetry etc) enabled. This was unintentional—having implemented the tests initially, I always worked under the assumption that the acceptance test runner was disabling telemetry upfront. I only discovered the opposite was true recently, seeing tests fail with mysterious errors when the telemetry server happens to be mis-behaving. This patch fixes the situation by opting the interactive tests out of telemetry by default. The two tests that check it (with a sensible fallback) now opt back in explicitly. Release note: None
Member
|
This change is |
tbg
approved these changes
Nov 18, 2019
Contributor
Author
|
tfyr! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
42537: cli/interactive_tests: opt out of telemetry by default r=knz a=knz Prior to this patch, the CLI interactive tests were running with diagnostic reporting (including update server checks, telemetry etc) enabled. This was unintentional—having implemented the tests initially, I always worked under the assumption that the acceptance test runner was disabling telemetry upfront. I only discovered the opposite was true recently, seeing tests fail with mysterious errors when the telemetry server happens to be mis-behaving. This patch fixes the situation by opting the interactive tests out of telemetry by default. The two tests that check it (with a sensible fallback) now opt back in explicitly. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
This was referenced Nov 18, 2019
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the CLI interactive tests were running with
diagnostic reporting (including update server checks, telemetry etc)
enabled.
This was unintentional—having implemented the tests initially, I
always worked under the assumption that the acceptance test runner was
disabling telemetry upfront. I only discovered the opposite was true
recently, seeing tests fail with mysterious errors when the telemetry
server happens to be mis-behaving.
This patch fixes the situation by opting the interactive tests out of
telemetry by default. The two tests that check it (with a sensible
fallback) now opt back in explicitly.
Release note: None