storage/engine: remove runWithAllEngines#42225
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 7, 2019
Merged
Conversation
Replace usage of `runWithAllEngines` with the more widely used for-loop over `mvccEngineImpls`. Fixes cockroachdb#42060 Release note: None
Member
itsbilal
approved these changes
Nov 7, 2019
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajkr and @sumeerbhola)
Collaborator
Author
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 7, 2019
42225: storage/engine: remove runWithAllEngines r=petermattis a=petermattis Replace usage of `runWithAllEngines` with the more widely used for-loop over `mvccEngineImpls`. Fixes #42060 Release note: None 42235: roachtest: update gopg ORM test r=yuzefovich a=yuzefovich There was a new release of gopg ORM which included a couple of PRs that improved the tool's testing infrastructure. Namely, the new release has several environment variables that can override the default options, and now we will use those. Also, there was a minor modification of error matching, so we can remove one of the tests from the ignore lists. Fixes: #41890. Release note: None 42268: bulk,importccl: re-read settings during ingestion r=dt a=dt Prior to this patch, the bulk-ingestion helpers were configured with size limits read from settings, but then executed, sometimes for hours, against those values that were passed in, not reacting to later changes in the underlying setting. This change plumbs those values though as func() int64 instead of int64, re-reading the setting value each time it is used and thus reflecting any changes to the underlying setting during execution. Also, while I'm here: switch uint64 to int64 to match our usual style guidelines. Release note (bug fix): fix bug where some settings changes were not reflected during currently running IMPORTs. Co-authored-by: Peter Mattis <petermattis@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace usage of
runWithAllEngineswith the more widely used for-loopover
mvccEngineImpls.Fixes #42060
Release note: None