Skip to content

storage/engine: remove runWithAllEngines#42225

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
petermattis:pmattis/run-with-all-engines
Nov 7, 2019
Merged

storage/engine: remove runWithAllEngines#42225
craig[bot] merged 1 commit intocockroachdb:masterfrom
petermattis:pmattis/run-with-all-engines

Conversation

@petermattis
Copy link
Copy Markdown
Collaborator

Replace usage of runWithAllEngines with the more widely used for-loop
over mvccEngineImpls.

Fixes #42060

Release note: None

Replace usage of `runWithAllEngines` with the more widely used for-loop
over `mvccEngineImpls`.

Fixes cockroachdb#42060

Release note: None
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajkr and @sumeerbhola)

@petermattis
Copy link
Copy Markdown
Collaborator Author

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Nov 7, 2019
42225: storage/engine: remove runWithAllEngines r=petermattis a=petermattis

Replace usage of `runWithAllEngines` with the more widely used for-loop
over `mvccEngineImpls`.

Fixes #42060

Release note: None

42235: roachtest: update gopg ORM test r=yuzefovich a=yuzefovich

There was a new release of gopg ORM which included a couple of PRs that
improved the tool's testing infrastructure. Namely, the new release has
several environment variables that can override the default options, and
now we will use those. Also, there was a minor modification of error
matching, so we can remove one of the tests from the ignore lists.

Fixes: #41890.

Release note: None

42268: bulk,importccl: re-read settings during ingestion r=dt a=dt

Prior to this patch, the bulk-ingestion helpers were configured with size limits read from settings,
but then executed, sometimes for hours, against those values that were passed in, not reacting to
later changes in the underlying setting.

This change plumbs those values though as func() int64 instead of int64, re-reading the setting value
each time it is used and thus reflecting any changes to the underlying setting during execution.

Also, while I'm here: switch uint64 to int64 to match our usual style guidelines.

Release note (bug fix): fix bug where some settings changes were not reflected during currently running IMPORTs.

Co-authored-by: Peter Mattis <petermattis@gmail.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: David Taylor <tinystatemachine@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 7, 2019

Build succeeded

@craig craig bot merged commit 07b0a34 into cockroachdb:master Nov 7, 2019
@petermattis petermattis deleted the pmattis/run-with-all-engines branch November 7, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage/engine: replace multiple engine testing methods from runWithAllEngines to for _, engineImpl := range mvccEngineImpls

3 participants