cli/cliflags: add COCKROACH_STORAGE_ENGINE env var#42185
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 5, 2019
Merged
cli/cliflags: add COCKROACH_STORAGE_ENGINE env var#42185craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
`roachprod` passes through COCKROACH_* env vars allowing `COCKROACH_STORAGE_ENGINE=pebble roachprod start` to work. Fixes cockroachdb#41620 Release note (cli change): Add COCKROACH_STORAGE_ENGINE env var which is tied to the `--storage-engine` flag. Allows selection of "pebble" as an alternative to the default of "rocksdb".
Collaborator
Author
|
I still need to check that |
Member
Collaborator
Author
|
Yep, verified |
itsbilal
approved these changes
Nov 5, 2019
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajkr and @sumeerbhola)
Collaborator
Author
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 5, 2019
42086: sql: remove hard limit handling from heuristic planner r=savoie a=savoie Previously, the heuristic planner function `applyLimit` propagated and set both hard and soft limits. Hard limit propagation is now handled in the optimizer by using rules to push Limit operators down the tree as far as is possible, and to remove Limits by adding hard limits to child Scan operators. As a result, a majority of the logic within `applyLimit` that supported propagating hard limits was never exercised, since optimization rules would have already eliminated situations in which Limit operators high up in the tree could be the cause of hard limits further down the tree. The one remaining case for which `applyLimit` was still responsible for propagating hard limits was eliminated by the normalization rule introduced in #41908. The entirety of `applyLimit` will eventually be removed and replaced by the optimizer. Removing hard limit propagation from it entirely is a step in this direction, and will make it easier to refactor soft limit propagation later. This patch changes `applyLimit` into `applySoftLimit`, which no longer performs any hard limit propagation; the responsibility for setting any hard limits on scanNodes and spoolNodes is now left to the optimizer. It also renames `setUnlimited` to `propagateSoftLimits` in order to indicate more clearly that this function is not used to remove any limits that might have been set on a node, but instead to trigger soft limit propagation in case a limit hint can be introduced further down the tree. In the case where the optimizer does not generate a limited Scan in place of a Limit around a Scan (because the Scan cannot be constrained), previously `applyLimit` would still set the `hardLimit` field of the scan. This change will result in the `softLimit` being set instead. The end state of the planNode tree is otherwise the same as before this refactor. Release note: None 42181: storage/engine: port the final few MVCC benchmarks to Pebble r=petermattis a=petermattis The `MVCCDeleteRange`, `ClearRange`, and `ClearIterRange` benchmarks appear to give nonsensical results. I suspect the benchmarks themselves are at fault and need to be rewritten. ``` name old time/op new time/op delta MVCCScanTransactionalData-16 4.20ms ± 1% 3.39ms ± 0% -19.15% (p=0.000 n=9+9) ``` Release note: None 42185: cli/cliflags: add COCKROACH_STORAGE_ENGINE env var r=petermattis a=petermattis `roachprod` passes through COCKROACH_* env vars allowing `COCKROACH_STORAGE_ENGINE=pebble roachprod start` to work. Fixes #41620 Release note (cli change): Add COCKROACH_STORAGE_ENGINE env var which is tied to the `--storage-engine` flag. Allows selection of "pebble" as an alternative to the default of "rocksdb". Co-authored-by: Céline O'Neil <celineloneil@gmail.com> Co-authored-by: Peter Mattis <petermattis@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roachprodpasses through COCKROACH_* env vars allowingCOCKROACH_STORAGE_ENGINE=pebble roachprod startto work.Fixes #41620
Release note (cli change): Add COCKROACH_STORAGE_ENGINE env var which
is tied to the
--storage-engineflag. Allows selection of "pebble" asan alternative to the default of "rocksdb".