Skip to content

c-deps: bump rocksdb for L0 file invariant fix#41728

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajkr:rocksdb-fix-l0-invariant
Oct 19, 2019
Merged

c-deps: bump rocksdb for L0 file invariant fix#41728
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajkr:rocksdb-fix-l0-invariant

Conversation

@ajkr
Copy link
Copy Markdown
Contributor

@ajkr ajkr commented Oct 18, 2019

Picks up cockroachdb/rocksdb#67.

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@ajkr
Copy link
Copy Markdown
Contributor Author

ajkr commented Oct 18, 2019

I will also backport this to 19.2 since we configured some tests to run with RocksDB assertions enabled in that release. Note this change only affects assertion enabled builds. In the future if we set Options::force_consistency_checks=true (which we've agreed we want to do before), then it will also affect release builds.

@ajkr ajkr requested review from itsbilal and sumeerbhola October 18, 2019 20:56
Copy link
Copy Markdown
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajkr
Copy link
Copy Markdown
Contributor Author

ajkr commented Oct 19, 2019

TFTR.

bors r+

craig bot pushed a commit that referenced this pull request Oct 19, 2019
41728: c-deps: bump rocksdb for L0 file invariant fix r=ajkr a=ajkr

Picks up cockroachdb/rocksdb#67.

Release note: None

Co-authored-by: Andrew Kryczka <andrew.kryczka2@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 19, 2019

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants