util/tracing: rename FormatRecordedSpans to Recording.String()#41494
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 18, 2019
Merged
util/tracing: rename FormatRecordedSpans to Recording.String()#41494craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
danhhz
approved these changes
Oct 10, 2019
pkg/util/tracing/tracer_span.go
Outdated
| l[i], l[j] = l[j], l[i] | ||
| } | ||
|
|
||
| // FormatRecordedSpans formats the given spans for human consumption, showing the |
Contributor
There was a problem hiding this comment.
s/FormatRecordedSpans/String/
Elevate the discoverability of FormatRecordedSpans() by making it the stringer for a Recording. Remove the inferior stringer I had previously added. Release note: None
f5f82ab to
cbe43c3
Compare
RaduBerinde
approved these changes
Oct 10, 2019
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @danhhz and @RaduBerinde)
andreimatei
commented
Oct 15, 2019
Contributor
Author
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
Contributor
Build failed (retrying...) |
Contributor
Build failed |
Contributor
Author
|
bors r+
…On Tue, Oct 15, 2019 at 12:33 PM craig[bot] ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=1539773&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41494?email_source=notifications&email_token=AAC4C4JB4UDMAD6KE4ATKY3QOXWENA5CNFSM4I7OTGMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJNHRA#issuecomment-542299076>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4C4J5EOVWEJGXVZOPM5TQOXWENANCNFSM4I7OTGMA>
.
|
Contributor
Build failed |
andreimatei
commented
Oct 17, 2019
Contributor
Author
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
craig bot
pushed a commit
that referenced
this pull request
Oct 17, 2019
33655: storage: skip TestWedgedReplicaDetection on test short r=andreimatei a=andreimatei Takes 10s. I've opened #33654 asking for an investigation. Release note: None 41391: roachtest: sort clusters in leftover clusters report r=andreimatei a=andreimatei They used to displayed in non-deterministic map iteration order. Release note: None 41401: roachtest: plumb the cluster id prefix from --cluster-id r=andreimatei a=andreimatei The flag was not hooked up to anything. Release justification: N/A Release note: None 41451: sql: use a different error code for communication failure r=andreimatei a=andreimatei Before this patch, DistSQL would use the the Postgres ConnectionFailure code when a network stream between processors on different nodes would break. This was the wrong code to use; Postgres uses this code for trouble with the client connection, not internal problems. There's evidence that middleware treats this code as a signal to tear down a connection (#31645). This patch switches to a new, CRDB-specific error code in the "internal error" class. Fixes #31645 Release note: None 41494: util/tracing: rename FormatRecordedSpans to Recording.String() r=andreimatei a=andreimatei Elevate the discoverability of FormatRecordedSpans() by making it the stringer for a Recording. Remove the inferior stringer I had previously added. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elevate the discoverability of FormatRecordedSpans() by making it the
stringer for a Recording. Remove the inferior stringer I had previously
added.
Release note: None