sqlsmith: tell sqlsmith about more things that vectorized supports#41075
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 25, 2019
Merged
sqlsmith: tell sqlsmith about more things that vectorized supports#41075craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The vectorized engine currently has support for AndExpr, OrExpr, CaseExpr, Like and NotLike, InExpr, and all of these things are now added to sqlsmith when vectorizable is true. Release justification: Category 1: Non-production code changes. Release note: None
Member
|
This change is |
Member
Author
|
I think some of these things we do not fully support (for example, something like this |
madelynnblue
approved these changes
Sep 25, 2019
Member
Author
|
Thanks for the review! bors r=mjibson |
craig bot
pushed a commit
that referenced
this pull request
Sep 25, 2019
41075: sqlsmith: tell sqlsmith about more things that vectorized supports r=mjibson a=yuzefovich The vectorized engine currently has support for AndExpr, OrExpr, CaseExpr, Like and NotLike, InExpr, and all of these things are now added to sqlsmith when vectorizable is true. Release justification: Category 1: Non-production code changes. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vectorized engine currently has support for AndExpr, OrExpr,
CaseExpr, Like and NotLike, InExpr, and all of these things are now
added to sqlsmith when vectorizable is true.
Release justification: Category 1: Non-production code changes.
Release note: None