cli: avoid running Example_demo_locality in the race detector#41044
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 25, 2019
Merged
cli: avoid running Example_demo_locality in the race detector#41044craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
|
I'll take this over. |
See the discussion on cockroachdb#41045: running a 9-node demo cluster under the race detector results in large CPU and ram usage that exceeds the CI budget. Since the various moving pieces in the code are race-tested in other places, we are solely interested here to unit test functionality, and it's not necessary to run in testrace. Release justification: removes test flakiness Release note: None
0e35d00 to
5df1260
Compare
Contributor
|
@tbg I have amended your commit, PTAL |
Contributor
|
(Note that the code could also encounter unrelated non-deterministic test flakiness until my other PR #41029 from yesterday, so that wasn't useless work) |
Member
Author
|
Thank you! bors r=knz |
craig bot
pushed a commit
that referenced
this pull request
Sep 25, 2019
41044: cli: avoid running Example_demo_locality in the race detector r=knz a=tbg Fixes #41045. See the discussion on #41045: running a 9-node demo cluster under the race detector results in large CPU and ram usage that exceeds the CI budget. Since the various moving pieces in the code are race-tested in other places, we are solely interested here to unit test functionality, and it's not necessary to run in `testrace`. Release justification: removes test flakiness Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41045.
See the discussion on #41045: running a 9-node demo cluster under the race detector results in large CPU and ram usage that exceeds the CI budget.
Since the various moving pieces in the code are race-tested in other places, we are solely interested here to unit test functionality, and it's not necessary to run in
testrace.Release justification: removes test flakiness
Release note: None