sql,sqlbase,client: revert #40581#40781
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Sep 16, 2019
Merged
Conversation
Member
|
This change is |
ajwerner
approved these changes
Sep 15, 2019
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
🙏 glad you found this
It’s going to need a release justification
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
fd7e95a to
13b6394
Compare
Member
Author
|
bors r+ |
Contributor
Build failed |
Member
Author
|
bors r+ |
Contributor
Build succeeded |
This was referenced Sep 16, 2019
craig bot
pushed a commit
that referenced
this pull request
Sep 17, 2019
40793: sql,sqlbase,client: bootstrap TableDescriptor timestamps from MVCC r=ajwerner a=ajwerner This PR adds back the changes in #40581 and deals with the fallout that led to #40781 in the 3rd commit. Release Justification: Fixes a bug formerly considered to be a release blocker. Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was buggy in presence of pre 19.1 backups; reverting until @ajwerner has a chance to fix and add tests.
Release justification: reverts a buggy patch