Revert "closedts: shorten target_duration from 30s to 5s"#40527
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 5, 2019
Merged
Conversation
This reverts commit 3e97e57. The last couple of weeks of experience show that tests become flakey with the target_duration set to 5s. This isn't overly surprising given that updates to table descriptors observe their own timestamp and thus can never be refreshed. See https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/sqlbase/structured.go#L1496-L1509 References cockroachdb#39643. Release note: None
Member
|
This change is |
Contributor
|
LGTM |
andy-kimball
approved these changes
Sep 5, 2019
Contributor
andy-kimball
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
Contributor
Author
|
bors r=andy-kimball |
Contributor
Author
|
TFTR |
craig bot
pushed a commit
that referenced
this pull request
Sep 5, 2019
40527: Revert "closedts: shorten target_duration from 30s to 5s" r=andy-kimball a=ajwerner This reverts commit 3e97e57. The last couple of weeks of experience show that tests become flakey with the target_duration set to 5s. This isn't overly surprising given that updates to table descriptors observe their own timestamp and thus can never be refreshed. See https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/sqlbase/structured.go#L1496-L1509 References #39643. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Contributor
Build succeeded |
This was referenced Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3e97e57.
The last couple of weeks of experience show that tests become flakey with
the target_duration set to 5s. This isn't overly surprising given that updates
to table descriptors observe their own timestamp and thus can never be
refreshed.
See https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/sqlbase/structured.go#L1496-L1509
References #39643.
Release note: None