Skip to content

store: pull updateMVCCGauges out of StoreMetrics lock, use atomics#40300

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
nvb:nvanbenschoten/removeMetrics
Aug 28, 2019
Merged

store: pull updateMVCCGauges out of StoreMetrics lock, use atomics#40300
craig[bot] merged 2 commits intocockroachdb:masterfrom
nvb:nvanbenschoten/removeMetrics

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Aug 28, 2019

The operations it performs are already atomic, so we can use atomic add instructions to avoid any critical section.

This was responsible for 8.15% of mutex contention on a YCSB run.

The change also removes MVCCStats from the storeMetrics interface, which addresses a long-standing TODO.

@nvb nvb requested a review from andreimatei August 28, 2019 18:35
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)

nvb added 2 commits August 28, 2019 15:50
This addresses a long-standing TODO.

Release note: None
The operations it performs are already atomic, so we can use atomic
add instructions to avoid any critical section.

This was responsible for 8.15% of mutex contention on a YCSB run.

Release note: None
@nvb nvb force-pushed the nvanbenschoten/removeMetrics branch from 5e906f4 to 0be2cc7 Compare August 28, 2019 19:50
@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Aug 28, 2019

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 28, 2019

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request Aug 28, 2019
40208: distsql: add disk spilling to lookup joiner r=solongordon a=solongordon

In lookup joins on partial index keys, there is no limit on how many
rows might be returned by any particular lookup, so the joinreader may
be buffering an unbounded number of rows into memory. I changed
joinreader to use a disk-backed row container rather than just storing
the rows in memory with no accounting.

Fixes #39044

Release note (bug fix): Lookup joins now spill to disk if the index
lookups return more rows than can be stored in memory.

40284: storage: issue swaps on AllocatorConsiderRebalance r=nvanbenschoten a=tbg

Change the rebalancing code so that it not only looks up a new replica to
add, but also picks one to remove. Both actions are then given to a
ChangeReplicas invocation which will carry it out atomically as long as
that feature is enabled.

Release note (bug fix): Replicas can now be moved between stores without
entering an intermediate configuration that violates the zone constraints.
Violations may still occur during zone config changes, decommissioning, and
in the presence of dead nodes (NB: the remainder be addressed in a future
change, so merge the corresponding release note)

40300: store: pull updateMVCCGauges out of StoreMetrics lock, use atomics r=nvanbenschoten a=nvanbenschoten

The operations it performs are already atomic, so we can use atomic add instructions to avoid any critical section.

This was responsible for 8.15% of mutex contention on a YCSB run.

The change also removes MVCCStats from the `storeMetrics` interface, which addresses a long-standing TODO.

40301: roachtest: Deflake clock jump test r=tbg a=bdarnell

These tests perform various clock jumps, then reverse them. The
reverse can cause a crash even if the original jump did not.
Add some sleeps to make things more deterministic and improve the
recovery process at the end of the test.

Fixes #38723

Release note: None

40305: exec: modify tests to catch bad selection vector access r=rafiss a=rafiss

The runTests helper will now cause a panic if a vectorized operator
tries to access a part of the selection vector that is out of bounds.
This identified bugs in the projection operator.

Release note: None

Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Co-authored-by: Ben Darnell <ben@cockroachlabs.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 28, 2019

Build succeeded

@craig craig bot merged commit 0be2cc7 into cockroachdb:master Aug 28, 2019
@nvb nvb deleted the nvanbenschoten/removeMetrics branch September 5, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants