changefeedccl: allow base64-encoded client certificate#39832
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 3, 2019
rolandcrosby:cdc-tls-cert
Merged
changefeedccl: allow base64-encoded client certificate#39832craig[bot] merged 1 commit intocockroachdb:masterfrom rolandcrosby:cdc-tls-cert
craig[bot] merged 1 commit intocockroachdb:masterfrom
rolandcrosby:cdc-tls-cert
Conversation
Member
Contributor
|
Nice. Does it work against a broker with TLS enabled and cert-based auth? |
danhhz
approved these changes
Aug 22, 2019
Contributor
danhhz
left a comment
There was a problem hiding this comment.
Awesome! assuming you've tested this locally and seen it work end-to-end
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @danhhz and @mberhault)
Author
|
Yep, I tested this against a broker with the |
mberhault
approved these changes
Aug 22, 2019
Contributor
Build failed |
Adds `client_cert` and `client_key` options to the `kafka://` changefeed URI scheme. Works like the existing `ca_cert` option: the user base64-encodes the contents of a PEM certificate and private key, and passes those base64 values as parameters in the Kafka URI. Fixes #39817. Release note (enterprise change): Client certificates are now supported for Kafka changefeed authentication.
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 3, 2019
39832: changefeedccl: allow base64-encoded client certificate r=rolandcrosby a=rolandcrosby Adds `client_cert` and `client_key` options to the `kafka://` changefeed URI scheme. Works like the existing `ca_cert` option: the user base64-encodes the contents of a PEM certificate and private key, and passes those base64 values as parameters in the Kafka URI. Fixes #39817. Release note (enterprise change): Client certificates are now supported for Kafka changefeed authentication. 39838: storage: fix stress flake r=ajwerner a=ajwerner While stressing storage for #39643 I encountered TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic failing under stress. It also complained about the parent testing.T having been failed when then using a child so fixed that too though in a perhaps messy way. ``` --- FAIL: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic (2.29s) --- PASS: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/initial_run (0.14s) client_test.go:1280: [NotLeaseHolderError] r1: replica (n1,s1):1 not lease holder; current lease is repl=(n3,s3):3 seq=4 start=1566532897.322355813,1 exp=1566532898.378802707,0 pro=1566532897.478824123,0 --- FAIL: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/after_restart (1.02s) testing.go:820: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test ``` Release note: None Co-authored-by: Roland Crosby <roland@cockroachlabs.com> Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
client_certandclient_keyoptions to thekafka://changefeed URI scheme. Works like the existing
ca_certoption:the user base64-encodes the contents of a PEM certificate and
private key, and passes those base64 values as parameters in the
Kafka URI.
Fixes #39817.
Release note (enterprise change): Client certificates are now
supported for Kafka changefeed authentication.