cli: Extending locality assignment for cockroach demo nodes#39786
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 21, 2019
Merged
cli: Extending locality assignment for cockroach demo nodes#39786craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This PR allows for setting multiple tiers of locality for cockroach demo nodes, as opposed to previous work allowing for only a single tier to be set for each node. Now, use a colon to separate the locality information for each demo node. For example, ``` --demo-locality=region=us-east1,az=1:region=us-east1,az=2:region=us-east1,az=3 ``` Fixes cockroachdb#39780. Release note: None
Member
|
This change is |
andreimatei
reviewed
Aug 21, 2019
complete! 1 of 0 LGTMs obtained (waiting on
Contributor
Author
|
Tftr! @awoods187 who should I talk to about getting this change documented? bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 21, 2019
39786: cli: Extending locality assignment for cockroach demo nodes r=rohany a=rohany This PR allows for setting multiple tiers of locality for cockroach demo nodes, as opposed to previous work allowing for only a single tier to be set for each node. Now, use a colon to separate the locality information for each demo node. For example, ``` --demo-locality=region=us-east1,az=1:region=us-east1,az=2:region=us-east1,az=3 ``` Fixes #39780. Release note (cli change): Extends the cockroach demo node locality setting to allow for multiple locality tiers per demo node. Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for setting multiple tiers of locality
for cockroach demo nodes, as opposed to previous work
allowing for only a single tier to be set for each node.
Now, use a colon to separate the locality information
for each demo node. For example,
Fixes #39780.
Release note (cli change): Extends the cockroach demo node locality setting to allow for multiple locality tiers per demo node.