roachtest: unskip overload/tpcc_olap#39567
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 12, 2019
Merged
Conversation
Now that cockroachdb#39172 has landed this test should pass reliably. Release note: None
Member
|
This change is |
ajwerner
commented
Aug 12, 2019
Contributor
Author
ajwerner
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained
craig bot
pushed a commit
that referenced
this pull request
Aug 12, 2019
39567: roachtest: unskip overload/tpcc_olap r=ajwerner a=ajwerner Now that #39172 has landed this test should pass reliably. I ran it 10s of times without a failure while working on that PR and 20 more times this morning. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Member
|
Feels good to get that without having had to introduce a general system for
admission control.
|
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #39172 has landed this test should pass reliably. I ran it 10s of times without a failure while working on that PR and 20 more times this morning.
Release note: None