rpc,nodedialer: excise methods which do not use ConnectionClass#39398
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 21, 2019
Merged
Conversation
Member
|
This change is |
Contributor
Author
|
Test flaked due to #39390, looking in to that. |
[cockroachdb#39172](https:github.com/cockroachdb/pull/39172) added the concept of connection class to create multiple connections to a given target. In order to reduce the adoption burden that PR introduced new methods for dialing connections, checking connection health, and retrieving circuit breakers which took a ConnectionClass and carried a `Class` suffix. It left the previous method signatures untouched, opting instead to convert them to a shorthand which passed DefaultClass to the new method. This PR moves all clients of these methods to use ConnectionClass explicitly. Release note: None
dafdb0e to
b3190af
Compare
andreimatei
reviewed
Aug 21, 2019
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
Contributor
Author
|
TFTR! bors r+ |
Contributor
Author
|
bors r+ Forgot it needed to be on its own line |
craig bot
pushed a commit
that referenced
this pull request
Aug 21, 2019
39398: rpc,nodedialer: excise methods which do not use ConnectionClass r=ajwerner a=ajwerner #39172 added the concept of connection class to create multiple connections to a given target. In order to reduce the adoption burden that PR introduced new methods for dialing connections, checking connection health, and retrieving circuit breakers which took a ConnectionClass and carried a `Class` suffix. It left the previous method signatures untouched, opting instead to convert them to a shorthand which passed DefaultClass to the new method. This PR moves all clients of these methods to use ConnectionClass explicitly. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#39172 added the concept of connection class to create multiple connections
to a given target. In order to reduce the adoption burden that PR introduced new
methods for dialing connections, checking connection health, and retrieving circuit
breakers which took a ConnectionClass and carried a
Classsuffix. It left the previousmethod signatures untouched, opting instead to convert them to a shorthand which passed DefaultClass to the new method.
This PR moves all clients of these methods to use ConnectionClass explicitly.
Release note: None