Skip to content

roachtest: skip kv/contention/nodes=4 for release-19.1#39149

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
nvb:nvanbenschoten/skipContention191
Jul 30, 2019
Merged

roachtest: skip kv/contention/nodes=4 for release-19.1#39149
craig[bot] merged 2 commits intocockroachdb:masterfrom
nvb:nvanbenschoten/skipContention191

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Jul 29, 2019

Fixes #39116.

release-19.1 is susceptible to the issues described in #36089, so it won't reliably pass this test.

nvb added 2 commits July 29, 2019 13:17
There was no v2.2.0, so this is bound to cause confusion.

Release note: None
release-19.1 is susceptible to the issues described in cockroachdb#36089, so it
won't reliably pass this test.

Release note: None
@nvb nvb requested a review from ajwerner July 29, 2019 17:19
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Jul 30, 2019

bors r=tbg

craig bot pushed a commit that referenced this pull request Jul 30, 2019
39149: roachtest: skip kv/contention/nodes=4 for release-19.1 r=tbg a=nvanbenschoten

Fixes #39116.

release-19.1 is susceptible to the issues described in #36089, so it won't reliably pass this test.

39160: storage: add DisableRaftLogQueue to StoreTestingKnobs r=tbg a=nvanbenschoten

Pulled from #38954, which I want to keep focused, especially with the PR's new secondary focus on refactoring entry application to be easier to mock and test.

Release note: None

39161: storage: address TODO in TestPushTxnHeartbeatTimeout r=tbg a=nvanbenschoten

Pulled from #38954, which I want to keep focused, especially with the PR's new secondary focus on refactoring entry application to be easier to mock and test.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 30, 2019

Build succeeded

@craig craig bot merged commit 5082052 into cockroachdb:master Jul 30, 2019
@nvb nvb deleted the nvanbenschoten/skipContention191 branch July 30, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: kv/contention/nodes=4 failed

3 participants