storage: remain compatible with transactions missing their minimum timestamp#39055
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 23, 2019
Merged
Conversation
Member
|
This change is |
…mestamp Fixes cockroachdb#39008. This was missed in cockroachdb#38782. I must have been thinking about the behavior we'll want to switch to in v20.1. Luckily, the issue was easily caught by `tpcc/mixed-headroom/n5cpu16`. Release note: None
f913fb3 to
ebbe064
Compare
tbg
approved these changes
Jul 23, 2019
Contributor
Author
|
bors r=tbg |
craig bot
pushed a commit
that referenced
this pull request
Jul 23, 2019
39055: storage: remain compatible with transactions missing their minimum timestamp r=tbg a=nvanbenschoten Fixes #39008. This was missed in #38782. I must have been thinking about the behavior we'll want to switch to in v20.1. Luckily, the issue was easily caught by `tpcc/mixed-headroom/n5cpu16`. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39008.
This was missed in #38782. I must have been thinking about the behavior
we'll want to switch to in v20.1. Luckily, the issue was easily caught
by
tpcc/mixed-headroom/n5cpu16.Release note: None