Skip to content

sql: fix swallowing Unsplit error#38433

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jeffrey-xiao:fix-truncate
Jun 26, 2019
Merged

sql: fix swallowing Unsplit error#38433
craig[bot] merged 1 commit intocockroachdb:masterfrom
jeffrey-xiao:fix-truncate

Conversation

@jeffrey-xiao
Copy link
Copy Markdown
Contributor

@jeffrey-xiao jeffrey-xiao commented Jun 26, 2019

Realized this condition should be negated.

Fixes #38131, #38095.

Release note: None

@jeffrey-xiao jeffrey-xiao requested review from a team June 26, 2019 14:21
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jun 26, 2019

This change is Reviewable

@jeffrey-xiao jeffrey-xiao requested review from ajwerner and nvb June 26, 2019 14:21
@jeffrey-xiao
sql: fix swallowing Unsplit error
922f297 
The condition for checking if the range has already been unsplit should
be negated.

Release note: None
@jeffrey-xiao
Copy link
Copy Markdown
Contributor Author

jeffrey-xiao commented Jun 26, 2019

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 26, 2019

Build failed

@jeffrey-xiao
Copy link
Copy Markdown
Contributor Author

jeffrey-xiao commented Jun 26, 2019 •
edited
Loading

Seems to be a TeamCity flake: `

Unexpected error: java.lang.RuntimeException: Failed to create context for build runner: Error creating bean with name 'jetbrains.buildServer.agent.impl.buildStages.startStages.steps.StepExecutor#0'

bors r+

craig bot pushed a commit that referenced this pull request Jun 26, 2019
@jeffrey-xiao
Merge #38433
c836e59 
38433: sql: fix swallowing Unsplit error r=jeffrey-xiao a=jeffrey-xiao

Realized this condition should be negated.

Fixes #38131, #38095.

Release note: None

Co-authored-by: Jeffrey Xiao <jeffrey.xiao1998@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 26, 2019

Build succeeded

@craig craig bot merged commit 922f297 into cockroachdb:master Jun 26, 2019
@jeffrey-xiao jeffrey-xiao deleted the fix-truncate branch August 15, 2019 17:48
@knz knz mentioned this pull request Nov 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajwerner ajwerner Awaiting requested review from ajwerner

1 more reviewer

@nvb nvb nvb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

roachtest: clearrange/checks=true failed

3 participants

@jeffrey-xiao @cockroach-teamcity @nvb