jobs: use hlc timestamp, not timeutil.Now#38387
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 24, 2019
Merged
jobs: use hlc timestamp, not timeutil.Now#38387craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, the jobs infrastructure was inconsistent about whether to use hlc or physical clocks to timestamp its updates, creations and deletes. This led to some test flakiness and likely some small real life issues. Now, we only use hlc timestamps. Release note: None
Member
|
This change is |
RaduBerinde
approved these changes
Jun 24, 2019
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @rytaft)
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 24, 2019
38387: jobs: use hlc timestamp, not timeutil.Now r=jordanlewis a=jordanlewis Closes #38226. Previously, the jobs infrastructure was inconsistent about whether to use hlc or physical clocks to timestamp its updates, creations and deletes. This led to some test flakiness and likely some small real life issues. Now, we only use hlc timestamps. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38226.
Previously, the jobs infrastructure was inconsistent about whether to
use hlc or physical clocks to timestamp its updates, creations and
deletes. This led to some test flakiness and likely some small real life
issues.
Now, we only use hlc timestamps.
Release note: None