roachtest: use 'fixtures import' from 'cockroach workload'#38022
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 5, 2019
Merged
roachtest: use 'fixtures import' from 'cockroach workload'#38022craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
danhhz
reviewed
Jun 5, 2019
Contributor
danhhz
left a comment
There was a problem hiding this comment.
Is the cockroach binary uploaded to this roachprod node? My scan of the code says no, but maybe I'm missing something
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @danhhz)
This was missed during cockroachdb#37726. Closes cockroachdb#37488. Touches cockroachdb#37163. Release note: None
Member
Author
|
It does now, thanks for checking! I thought I checked but now I'm not sure what I did. bors r=danhhz |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed during #37726.
Closes #37488.
Touches #37163.
Release note: None