roachpb: avoid advertising UnhandledRetryableError as client-visible#37998
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 4, 2019
Merged
roachpb: avoid advertising UnhandledRetryableError as client-visible#37998craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Requested by @andreimatei: the "client-visible" retry errors are those that trigger a SQL code 40001. Since `UnhandledRetryableError` does not flow back through SQL, it needs not be marked by this interface. Release note: None
59c95ac to
c0ea5a9
Compare
andreimatei
approved these changes
Jun 4, 2019
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
Contributor
Author
|
thanks bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 4, 2019
37995: sql/delegate: move delegateShowDatabaseIndexes to its own file r=knz a=knz (we generally try to use different files for different concerns) Release note: None 37998: roachpb: avoid advertising UnhandledRetryableError as client-visible r=knz a=knz Requested by @andreimatei: the "client-visible" retry errors are those that trigger a SQL code 40001. Since `UnhandledRetryableError` does not flow back through SQL, it needs not be marked by this interface. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @andreimatei: the "client-visible" retry errors are those
that trigger a SQL code 40001. Since
UnhandledRetryableErrordoesnot flow back through SQL, it needs not be marked by this interface.
Release note: None