Skip to content

sql/row: use assertion failures instead of panics#37802

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20190524-row-assert
May 24, 2019
Merged

sql/row: use assertion failures instead of panics#37802
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20190524-row-assert

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented May 24, 2019

(I was debugging a test and these panics were getting in the way)

Release note: None

@knz knz requested review from a team, RaduBerinde and jordanlewis May 24, 2019 18:06
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@knz knz force-pushed the 20190524-row-assert branch from 799dee9 to 0cc1cdb Compare May 24, 2019 18:35
@knz knz force-pushed the 20190524-row-assert branch from 0cc1cdb to 79cf9da Compare May 24, 2019 18:37
@knz knz requested a review from madelynnblue May 24, 2019 20:31
@knz
Copy link
Copy Markdown
Contributor Author

knz commented May 24, 2019

TFYR!

bors r+

craig bot pushed a commit that referenced this pull request May 24, 2019
37802: sql/row: use assertion failures instead of panics r=knz a=knz

(I was debugging a test and these panics were getting in the way)

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 24, 2019

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants