roachprod: distribute authorized_keys to creating user on gce#37438
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 4, 2019
Conversation
Member
|
This change is |
andreimatei
approved these changes
May 16, 2019
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
LGTM thanks!
What's left for us to start using the shared used on GCE too, for uniformity with AWS (and because it seems saner)? Could "we" just do it here? :)
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @andreimatei)
pkg/cmd/roachprod/install/cluster_synced.go, line 701 at r1 (raw file):
sess.SetStdin(bytes.NewReader(c.AuthorizedKeys)) const cmd = `
mind sprinkling some comments around here about what's going on?
Previously in cockroachdb#35759 logic was added to read public keys from the gce project metadata and distribute them into the authorized_keys file of the shared user (ubuntu) on AWS. cockroachdb#37077 primarily served to distribute known_hosts files to the shared user (ubuntu) on both AWS and GCE as well as the creating user on GCE. That change also included logic to write the authorized_keys file to the shared user on GCE (as opposed to just AWS) in anticipation of switching roachprod to use the shared user across cloud providers. This change extends the previous change by also distributing all public keys to the authorized_keys file for the cluster creating user on GCE. Release note: None
ajwerner
commented
Jun 4, 2019
Contributor
Author
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachprod/install/cluster_synced.go, line 701 at r1 (raw file):
Previously, andreimatei (Andrei Matei) wrote…
mind sprinkling some comments around here about what's going on?
Done.
f94f5ef to
dc83597
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 4, 2019
37438: roachprod: distribute authorized_keys to creating user on gce r=ajwerner a=ajwerner Previously in #35759 logic was added to read public keys from the gce project metadata and distribute them into the authorized_keys file of the shared user (ubuntu) on AWS. #37077 primarily served to distribute known_hosts files to the shared user (ubuntu) on both AWS and GCE as well as the creating user on GCE. That change also included logic to write the authorized_keys file to the shared user on GCE (as opposed to just AWS) in anticipation of switching roachprod to use the shared user across cloud providers. This change extends the previous change by also distributing all public keys to the authorized_keys file for the cluster creating user on GCE. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in #35759 logic was added to read public keys from the gce project
metadata and distribute them into the authorized_keys file of the shared user
(ubuntu) on AWS. #37077 primarily served to distribute known_hosts files to
the shared user (ubuntu) on both AWS and GCE as well as the creating user on GCE.
That change also included logic to write the authorized_keys file to the shared
user on GCE (as opposed to just AWS) in anticipation of switching roachprod to
use the shared user across cloud providers. This change extends the previous
change by also distributing all public keys to the authorized_keys file for the
cluster creating user on GCE.
Release note: None