storage: remove TestStoreRangeRemoveDead#37351
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 8, 2019
Merged
Conversation
This test was an abomination, so we would have to rewrite it. However, there is already coverage for this situation in both the allocator unit tests and in plenty of higher-level tests (roachtest, etc), so it's easier to just remove this test. Closes cockroachdb#34081. Release note: None
Member
|
This change is |
nvb
approved these changes
May 7, 2019
Member
Author
|
bors r=nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
May 8, 2019
37351: storage: remove TestStoreRangeRemoveDead r=nvanbenschoten a=tbg This test was an abomination, so we would have to rewrite it. However, there is already coverage for this situation in both the allocator unit tests and in plenty of higher-level tests (roachtest, etc), so it's easier to just remove this test. Closes #34081. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Contributor
Build succeeded |
This was referenced Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was an abomination, so we would have to rewrite it. However,
there is already coverage for this situation in both the allocator unit
tests and in plenty of higher-level tests (roachtest, etc), so it's
easier to just remove this test.
Closes #34081.
Release note: None