storage: deflake TestStoreRangeMergeRaftSnapshot#37350
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 7, 2019
Merged
storage: deflake TestStoreRangeMergeRaftSnapshot#37350craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Make sure Raft message we wanted to be dropped are 100% dropped, or the follower we were expecting to get a snapshot would get by without one, confusing the test. Note that this hasn't failed since roughly Christmas 2018, but the bug is there (we've fixed similar ones in different places, which is where I copied the snippet from). Might as well prevent this from becoming an issue again in the future. Closes cockroachdb#33006. Release note: None
Member
|
This change is |
nvb
approved these changes
May 7, 2019
Member
Author
|
bors r=nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
May 7, 2019
37350: storage: deflake TestStoreRangeMergeRaftSnapshot r=nvanbenschoten a=tbg Make sure Raft messages we wanted to be dropped are 100% dropped, or the follower we were expecting to get a snapshot would get by without one, confusing the test. Note that this hasn't failed since roughly Christmas 2018, but the bug is there (we've fixed similar ones in different places, which is where I copied the snippet from). Might as well prevent this from becoming an issue again in the future. Closes #33006. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Contributor
Build succeeded |
Contributor
|
I just got a failure in TestStoreRangeMergeRaftSnapshot in https://teamcity.cockroachdb.com/viewLog.html?buildId=1279557&tab=buildResultsDiv&buildTypeId=Cockroach_UnitTests_Test. Perhaps related to this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure Raft messages we wanted to be dropped are 100% dropped,
or the follower we were expecting to get a snapshot would get by
without one, confusing the test.
Note that this hasn't failed since roughly Christmas 2018, but
the bug is there (we've fixed similar ones in different places,
which is where I copied the snippet from). Might as well prevent
this from becoming an issue again in the future.
Closes #33006.
Release note: None