sql: fix dist planning of window fns with mutations#37171
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 27, 2019
Merged
sql: fix dist planning of window fns with mutations#37171craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
RaduBerinde
approved these changes
Apr 26, 2019
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @yuzefovich)
Member
Author
|
TFTR! bors r+ |
Contributor
Build failed |
Release note (bug fix): permit planning of window functions within mutation statements (and others that can't be distributed).
2d6c51f to
0a347c3
Compare
Member
Author
|
bors r+ |
Contributor
Build failed |
Member
Author
|
Lint OOM... bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 27, 2019
37171: sql: fix dist planning of window fns with mutations r=jordanlewis a=jordanlewis Fixes #36830. Release note (bug fix): permit planning of window functions within mutation statements (and others that can't be distributed). Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36830.
Release note (bug fix): permit planning of window functions within
mutation statements (and others that can't be distributed).