roachtest: create new import/tpcc/warehouses=4000/geo test#36997
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 29, 2019
Merged
roachtest: create new import/tpcc/warehouses=4000/geo test#36997craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Closes cockroachdb#36861. This test runs a geo-distributed import in the same configuration as the one we saw cause issues with cockroachdb#36861. I'm testing now to see if this will actually trigger the consistency failure without the fix from cockroachdb#36939. Release note: None
Member
|
This change is |
Member
|
No repro? 🍿 |
Contributor
Author
|
The test actually passed three times yesterday, which surprised me. I'm still poking at. |
Member
|
Hmm, three times isn't a lot. Hopefully just got lucky. Hit it with the old roachprod stresser? |
Contributor
Author
|
Still no reproductions after another 25 attempts. I went back and tried the exact steps we took in #36861 to trigger this and haven't had any luck there either after 4 attempts. These take 2 hours each so they're not particularly easy/cost-effective to stress. This test is certainly testing the class of cluster configuration that we saw trigger #36861, so I don't think it's worth putting any more time into trying to repro that exact bug after the fact. I'm going to merge this as is and close that issue. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 29, 2019
36997: roachtest: create new import/tpcc/warehouses=4000/geo test r=nvanbenschoten a=nvanbenschoten Closes #36861. This test runs a geo-distributed import in the same configuration as the one we saw cause issues with #36861. I'm testing now to see if this will actually trigger the consistency failure without the fix from #36939. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36861.
This test runs a geo-distributed import in the same configuration
as the one we saw cause issues with #36861.
I'm testing now to see if this will actually trigger the consistency
failure without the fix from #36939.
Release note: None