changefeedccl: remove deprecated changefeed.min_high_water metric#36915
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 17, 2019
Merged
changefeedccl: remove deprecated changefeed.min_high_water metric#36915craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
It was replaced by max_behind_nanos in 19.1. Release note (backwards-incompatible change): Removed the deprecated `changefeed.min_high_water` metric; use `changefeed.max_behind_nanos` instead.
Member
|
This change is |
nvb
approved these changes
Apr 17, 2019
Contributor
Author
|
TFTR! bors r=nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
Apr 17, 2019
36867: storage: take an engine checkpoint during failing consistency checks r=andreimatei a=tbg This takes a checkpoint on the nodes with replicas of a failing range, before the failure leads to nodes shutting down. The checkpoint will, for the replicas of the affected range, be taken at the same Raft log position. Release note: None 36915: changefeedccl: remove deprecated changefeed.min_high_water metric r=nvanbenschoten a=danhhz It was replaced by max_behind_nanos in 19.1. Release note (backwards-incompatible change): Removed the deprecated `changefeed.min_high_water` metric; use `changefeed.max_behind_nanos` instead. Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com> Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was replaced by max_behind_nanos in 19.1.
Release note (backwards-incompatible change): Removed the deprecated
changefeed.min_high_watermetric; usechangefeed.max_behind_nanosinstead.