Skip to content

cli/debug: teach debug raft-log to decode DeleteRange ops#36860

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/printDelRange
Apr 16, 2019
Merged

cli/debug: teach debug raft-log to decode DeleteRange ops#36860
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/printDelRange

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Apr 16, 2019

This change extends #35528 to support DeleteRange operations. I was
seeing the following log frequently when running the command:

write batch:
failed to decode: unexpected type 15

This fixes that.

write batch:
Delete Range: [0.000000000,0 /Table/68/1/29/4/2413 (0xcc89a58cf7096d00): , 0.000000000,0 /Table/68/1/31/4/1210 (0xcc89a78cf704ba00): )
Delete: 0.000000000,0 /Table/68/1/29/4/2413 (0xcc89a58cf7096d00):
Delete: 0.000000000,0 /Table/68/1/31/4/1209 (0xcc89a78cf704b900):

Release note: None

This change extends cockroachdb#35528 to support DeleteRange operations. I was
seeing the following log frequently when running the command:
```
< write batch:
< failed to decode: unexpected type 15
```

This should fix that.

Release note: None
@nvb nvb requested a review from andreimatei April 16, 2019 02:56
@nvb nvb requested a review from a team as a code owner April 16, 2019 02:56
@nvb nvb requested a review from a team April 16, 2019 02:56
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Apr 16, 2019

bors r+

craig bot pushed a commit that referenced this pull request Apr 16, 2019
36860: cli/debug: teach debug raft-log to decode DeleteRange ops r=nvanbenschoten a=nvanbenschoten

This change extends #35528 to support DeleteRange operations. I was
seeing the following log frequently when running the command:
```
write batch:
failed to decode: unexpected type 15
```

This fixes that.

```
write batch:
Delete Range: [0.000000000,0 /Table/68/1/29/4/2413 (0xcc89a58cf7096d00): , 0.000000000,0 /Table/68/1/31/4/1210 (0xcc89a78cf704ba00): )
Delete: 0.000000000,0 /Table/68/1/29/4/2413 (0xcc89a58cf7096d00):
Delete: 0.000000000,0 /Table/68/1/31/4/1209 (0xcc89a78cf704b900):
```

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 16, 2019

Build succeeded

@craig craig bot merged commit 9e5e26f into cockroachdb:master Apr 16, 2019
@nvb nvb deleted the nvanbenschoten/printDelRange branch April 17, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants