roachtest: Rate limit connection establishment#36824
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 13, 2019
Merged
roachtest: Rate limit connection establishment#36824craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Acquiring connections with unlimited parallelism triggers syn flood
protection on the server and can sometimes lead to failures. This was
especially common in tests using the tpcc-1000 dataset (which also
creates a large number of connections.
Failures fixed by this change look like
stdout:
Error: read tcp 10.142.0.43:37862->10.142.0.112:26257: read: connection reset by peer
Error: exit status 1
Fixes cockroachdb#36745
Release note: None
Member
|
This change is |
Contributor
Author
|
I empirically validated this while stressing the scrub test for #35986. It was failing about 20% of the time with this error, and with this change I've run a hundred iterations without seeing it. |
Member
|
LGTM, thanks for fixing! Ideally we would have one semaphore per host (URL), but that won't matter with tpcc (where each host has its own |
Member
|
Thanks for fixing this Ben!
…On Sat, Apr 13, 2019, 18:28 RaduBerinde ***@***.***> wrote:
LGTM, thanks for fixing!
Ideally we would have one semaphore per host (URL), but that won't matter
with tpcc (where each host has its own MultiConnPool) and I don't think
other workloads use a ton of connections.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#36824 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135KRVVsxQng2L8Lx-QUtYnzWPoU78ks5vggWmgaJpZM4cuGMq>
.
|
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 13, 2019
36824: roachtest: Rate limit connection establishment r=bdarnell a=bdarnell
Acquiring connections with unlimited parallelism triggers syn flood
protection on the server and can sometimes lead to failures. This was
especially common in tests using the tpcc-1000 dataset (which also
creates a large number of connections.
Failures fixed by this change look like
stdout:
Error: read tcp 10.142.0.43:37862->10.142.0.112:26257: read: connection reset by peer
Error: exit status 1
Fixes #36745
Release note: None
Co-authored-by: Ben Darnell <ben@bendarnell.com>
This was referenced Apr 13, 2019
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acquiring connections with unlimited parallelism triggers syn flood
protection on the server and can sometimes lead to failures. This was
especially common in tests using the tpcc-1000 dataset (which also
creates a large number of connections.
Failures fixed by this change look like
Fixes #36745
Release note: None