workload/tpcc: add missing new_order -> order foreign key#35891
Closed
nvb wants to merge 1 commit intocockroachdb:masterfrom
Closed
workload/tpcc: add missing new_order -> order foreign key#35891nvb wants to merge 1 commit intocockroachdb:masterfrom
nvb wants to merge 1 commit intocockroachdb:masterfrom
Conversation
See page 15 of the spec: http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-c_v5.11.0.pdf Release note: None
Member
|
This change is |
Member
|
LGTM, are we sure we want to add this right now though? It might change how the workload behaves. If we're already in a period of trying to stabilize, will changing this make things harder? |
Contributor
Author
|
Yeah, that's a good point. I was mainly throwing this in a PR to avoid forgetting about it. At a minimum I don't want to merge until #35812 is resolved because it changes the behavior of |
nvb
added a commit
to nvb/cockroach
that referenced
this pull request
Apr 15, 2019
Closes cockroachdb#35891. See page 15 of the spec: http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-c_v5.11.0.pdf Release note: None
Contributor
Author
|
Closing in favor of #36854. |
nvb
added a commit
to nvb/cockroach
that referenced
this pull request
May 20, 2019
Closes cockroachdb#35891. See page 15 of the spec: http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-c_v5.11.0.pdf Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See page 15 of the spec:
http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-c_v5.11.0.pdf
Release note: None