sql/logictest: reveal error details if present#35827
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 16, 2019
Merged
sql/logictest: reveal error details if present#35827craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Before: ``` testdata/logic_test/assertion_error:4: expected success, but found crdb_internal.force_assertion_error(): internal error: woo ``` After (for example, after cockroachdb#35820 is separately applied): ``` testdata/logic_test/assertion_error:4: expected success, but found (XX000) crdb_internal.force_assertion_error(): internal error: woo sql/sem/builtins/builtins.go:2815: in func211() DETAIL: stack trace: github.com/cockroachdb/cockroach/pkg/sql/sem/builtins/builtins.go:2815: in func211() github.com/cockroachdb/cockroach/pkg/sql/sem/tree/eval.go:3651: in Eval() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/expr.go:196: in eval() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:375: in ProcessRow() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:778: in ProcessRowHelper() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/values.go:126: in Next() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/base.go:174: in Run() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:801: in Run() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/flow.go:627: in Run() github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:252: in Run() github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:839: in PlanAndRun() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1112: in execWithDistSQLEngine() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:948: in dispatchToExecutionEngine() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:456: in execStmtInOpenState() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:102: in execStmt() github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1178: in run() github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:429: in ServeConn() github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:337: in func4() NOTE: internal errors may have more details in log. Use -show-logs. ``` Release note: None
Member
|
This change is |
andy-kimball
approved these changes
Mar 16, 2019
Contributor
andy-kimball
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball and @RaduBerinde)
Contributor
Author
|
you're welcome! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 16, 2019
35827: sql/logictest: reveal error details if present r=knz a=knz Before: ``` testdata/logic_test/assertion_error:4: expected success, but found crdb_internal.force_assertion_error(): internal error: woo ``` After (for example, after #35820 is separately applied): ``` testdata/logic_test/assertion_error:4: expected success, but found (XX000) crdb_internal.force_assertion_error(): internal error: woo sql/sem/builtins/builtins.go:2815: in func211() DETAIL: stack trace: github.com/cockroachdb/cockroach/pkg/sql/sem/builtins/builtins.go:2815: in func211() github.com/cockroachdb/cockroach/pkg/sql/sem/tree/eval.go:3651: in Eval() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/expr.go:196: in eval() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:375: in ProcessRow() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:778: in ProcessRowHelper() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/values.go:126: in Next() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/base.go:174: in Run() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:801: in Run() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/flow.go:627: in Run() github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:252: in Run() github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:839: in PlanAndRun() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1112: in execWithDistSQLEngine() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:948: in dispatchToExecutionEngine() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:456: in execStmtInOpenState() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:102: in execStmt() github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1178: in run() github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:429: in ServeConn() github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:337: in func4() NOTE: internal errors may have more details in log. Use -show-logs. ``` Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
Member
|
Thank you! Easier to read than panic stacktraces too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After (for example, after #35820 is separately applied):
Release note: None