util/log: make log.Safe() work with other fmt specs than %v#35825
Closed
knz wants to merge 1 commit intocockroachdb:masterfrom
Closed
util/log: make log.Safe() work with other fmt specs than %v#35825knz wants to merge 1 commit intocockroachdb:masterfrom
knz wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
c264a54 to
f1fbde2
Compare
Release note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 18, 2019
35821: sql,*: error handling improvements r=knz a=knz Subsumes #35825. Subsumes #35820. This PR replaces uses of `errors.New`, `errors.Errorf` and `errors.Wrap` by their `pgerror` equivalents. It also embeds the subsumed PRs; see those PR's discussion for details. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Author
|
Subsumed by #35821 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes alongside #35821.
We want to use
log.Safe()also for parameters printed via %d, etc.Release note: None