sqlbase: fix invalid uses of pgerorr.NewErrorf#35824
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 16, 2019
Merged
sqlbase: fix invalid uses of pgerorr.NewErrorf#35824craig[bot] merged 1 commit intocockroachdb:masterfrom
pgerorr.NewErrorf#35824craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Release note: None
Member
|
This change is |
andy-kimball
approved these changes
Mar 16, 2019
Contributor
andy-kimball
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andreimatei and @andy-kimball)
Contributor
Author
|
TFYR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 16, 2019
35824: sqlbase: fix invalid uses of `pgerorr.NewErrorf` r=knz a=knz This goes alongside #35821. It's not valid to pass an opaque string as the `format` argument of a formatting function. Also, wrap long lines. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
andreimatei
reviewed
Mar 16, 2019
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
points if you make a pgerror.NewError().
Reviewable status:
Contributor
Build succeeded |
Contributor
Author
it was already there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes alongside #35821.
It's not valid to pass an opaque string as the
formatargument of a formatting function.Also, wrap long lines.
Release note: None