enterprise: Report per-store encryption type in metrics and telemetry.#35506
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 8, 2019
Merged
Conversation
Member
|
This change is |
dt
reviewed
Mar 7, 2019
Contributor
dt
left a comment
There was a problem hiding this comment.
Telemetry side LGTM (didn't look at cpp side)
Reviewed 2 of 8 files at r1, 5 of 5 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @bdarnell and @dt)
bdarnell
approved these changes
Mar 7, 2019
Contributor
bdarnell
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, 5 of 5 files at r2.
Reviewable status:
be21fd1 to
a109e52
Compare
29 tasks
a109e52 to
3af4ffe
Compare
Add a per-store metric `rocksdb.encryption.algorithm` describing the cipher in use for encryption-at-rest. This is the enum representing the cipher type: ``` // No encryption. Plaintext = 0; // AES in counter mode with various key lengths. AES128_CTR = 1; AES192_CTR = 2; AES256_CTR = 3; ``` Release note (enterprise change): add per-store metrics `rocksdb.encryption.algorithm`, enum describing the encryption cipher in use.
3af4ffe to
2bc10e7
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 8, 2019
35506: enterprise: Report per-store encryption type in metrics and telemetry. r=mberhault a=mberhault Fixes #35286 Add a per-store metric `rocksdb.encryption.algorithm` describing the cipher in use for encryption-at-rest. This is the enum representing the cipher type: ``` enum EncryptionType { // No encryption. Plaintext = 0; // AES in counter mode with various key lengths. AES128_CTR = 1; AES192_CTR = 2; AES256_CTR = 3; } ``` Release note (enterprise change): add per-store metrics `rocksdb.encryption.algorithm`, enum describing the encryption cipher in use. Co-authored-by: marc <marc@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35286
Add a per-store metric
rocksdb.encryption.algorithmdescribing thecipher in use for encryption-at-rest.
This is the enum representing the cipher type:
Release note (enterprise change): add per-store metrics
rocksdb.encryption.algorithm, enum describing the encryption cipher inuse.